| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Wolfgang Walther <walther(at)technowledgy(dot)de> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, peter(at)eisentraut(dot)org, Christophe Pettus <xof(at)thebuild(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| Date: | 2024-03-20 13:35:51 |
| Message-ID: | ZfrmN4WHuJgD95fw@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Mar 20, 2024 at 10:39:20AM +0100, Wolfgang Walther wrote:
> Peter Eisentraut:
> > We could turn it around and do
> >
> > #if defined(__linux__)
> > #if defined(__GLIBC__) || defined(__UCLIBC__ )
> > #define PS_USE_CLOBBER_ARGV
> > #else
> > #define PS_USE_NONE
> > #endif
> > #endif
>
> This works as well.
Yes, I prefer this. I am worried the environ hackery will bite us
someday and the cause will be hard to find.
> I also put together a PoC of what was mentioned in musl's mailing list:
> Instead of clobbering environ at all, exec yourself again with padded argv0.
> This works, too. Attached.
It is hard to imagine why we would add an extra exec on every Linux
server start for this.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Only you can decide what is important to you.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2024-03-20 13:37:30 | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| Previous Message | Kritika Agarwal | 2024-03-20 12:27:28 | Re: BUG #18401: Cannot install |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2024-03-20 13:37:30 | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| Previous Message | Masahiko Sawada | 2024-03-20 13:30:06 | Re: [PoC] Improve dead tuple storage for lazy vacuum |