| From: | Wolfgang Walther <walther(at)technowledgy(dot)de> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, peter(at)eisentraut(dot)org |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Christophe Pettus <xof(at)thebuild(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| Date: | 2024-03-20 09:39:20 |
| Message-ID: | 477fa513-6bf0-456d-8d24-1e22a19df671@technowledgy.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Thomas Munro:
> On Wed, Mar 20, 2024 at 3:03 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> +1 for stopping only at one of those two names.
>
> Here's one like that for Wolfgang to test on musl.
Works fine.
Peter Eisentraut:
> We could turn it around and do
>
> #if defined(__linux__)
> #if defined(__GLIBC__) || defined(__UCLIBC__ )
> #define PS_USE_CLOBBER_ARGV
> #else
> #define PS_USE_NONE
> #endif
> #endif
This works as well.
I also put together a PoC of what was mentioned in musl's mailing list:
Instead of clobbering environ at all, exec yourself again with padded
argv0. This works, too. Attached.
Best,
Wolfgang
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-ps-status-exec.patch | text/x-patch | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mingjun Yang | 2024-03-20 09:55:05 | performance: `tuplehash_iterate` and `group by` question, very slow |
| Previous Message | Andrew Dunstan | 2024-03-20 07:16:14 | Re: Regression tests fail with musl libc because libpq.so can't be loaded |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-03-20 09:41:33 | Re: Catalog domain not-null constraints |
| Previous Message | Michael Banck | 2024-03-20 09:30:54 | Re: Possibility to disable `ALTER SYSTEM` |