| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tristan Partin <tristan(at)neon(dot)tech> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Remove a FIXME and unused variables in Meson |
| Date: | 2024-03-14 05:15:50 |
| Message-ID: | ZfKIBtOH63tvI09G@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 14, 2024 at 12:13:18AM -0500, Tristan Partin wrote:
> One of them adds version gates to two LLVM flags (-frwapv,
> -fno-strict-aliasing). I believe we moved the minimum LLVM version recently,
> so these might not be necessary, but maybe it helps for historictal reasons.
> If not, I'll just remove the comment in a different patch.
>
> Second patch removes some unused variables. Were they analogous to things in
> autotools and the Meson portions haven't been added yet?
>
> I was looking into adding LLVM JIT support to Meson since there is a TODO
> about it, but it wasn't clear what was missing except adding some variables
> into the PGXS Makefile.
It looks like you have forgotten to attach the patches. :)
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2024-03-14 05:17:04 | Re: Remove a FIXME and unused variables in Meson |
| Previous Message | Tristan Partin | 2024-03-14 05:13:18 | Remove a FIXME and unused variables in Meson |