Re: Remove a FIXME and unused variables in Meson

From: "Tristan Partin" <tristan(at)neon(dot)tech>
To: "Michael Paquier" <michael(at)paquier(dot)xyz>
Cc: <pgsql-hackers(at)postgresql(dot)org>, "Thomas Munro" <thomas(dot)munro(at)gmail(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de>
Subject: Re: Remove a FIXME and unused variables in Meson
Date: 2024-03-14 05:17:04
Message-ID: CZT7V7VCDQG9.3BVU68NHJB0X3@neon.tech
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu Mar 14, 2024 at 12:15 AM CDT, Michael Paquier wrote:
> On Thu, Mar 14, 2024 at 12:13:18AM -0500, Tristan Partin wrote:
> > One of them adds version gates to two LLVM flags (-frwapv,
> > -fno-strict-aliasing). I believe we moved the minimum LLVM version recently,
> > so these might not be necessary, but maybe it helps for historictal reasons.
> > If not, I'll just remove the comment in a different patch.
> >
> > Second patch removes some unused variables. Were they analogous to things in
> > autotools and the Meson portions haven't been added yet?
> >
> > I was looking into adding LLVM JIT support to Meson since there is a TODO
> > about it, but it wasn't clear what was missing except adding some variables
> > into the PGXS Makefile.
>
> It looks like you have forgotten to attach the patches. :)

CLASSIC!

--
Tristan Partin
Neon (https://neon.tech)

Attachment Content-Type Size
v1-0001-Protect-adding-llvm-flags-if-found-version-is-not.patch text/x-patch 1.2 KB
v1-0002-Remove-some-unused-variables-in-Meson.patch text/x-patch 2.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2024-03-14 05:23:32 Re: pg16: XX000: could not find pathkey item to sort
Previous Message Michael Paquier 2024-03-14 05:15:50 Re: Remove a FIXME and unused variables in Meson