| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve readability by using designated initializers when possible |
| Date: | 2024-03-01 05:08:40 |
| Message-ID: | ZeFi2H1lJ5sz4sU9@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 01, 2024 at 05:34:05AM +0100, Jelte Fennema-Nio wrote:
> diff --git a/src/include/mb/pg_wchar.h b/src/include/mb/pg_wchar.h
> index fd91aefbcb7..32e25a1a6ea 100644
> --- a/src/include/mb/pg_wchar.h
> +++ b/src/include/mb/pg_wchar.h
> @@ -225,7 +225,8 @@ typedef unsigned int pg_wchar;
> * PostgreSQL encoding identifiers
> *
> * WARNING: If you add some encoding don't forget to update
> - * the pg_enc2name_tbl[] array (in src/common/encnames.c) and
> + * the pg_enc2name_tbl[] array (in src/common/encnames.c),
> + * the pg_enc2gettext_tbl[] array (in src/common/encnames.c) and
> * the pg_wchar_table[] array (in src/common/wchar.c) and to check
> * PG_ENCODING_BE_LAST macro.
Mostly OK to me. Just note that this comment is incorrect because
pg_enc2gettext_tbl[] includes elements in the range
[PG_SJIS,_PG_LAST_ENCODING_[ ;)
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-03-01 05:14:47 | Re: ALTER TABLE SET ACCESS METHOD on partitioned tables |
| Previous Message | Jeff Davis | 2024-03-01 05:05:34 | Re: Built-in CTYPE provider |