| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve readability by using designated initializers when possible |
| Date: | 2024-03-01 04:34:05 |
| Message-ID: | CAGECzQQPhVCarZY595ZyJ7gKEU=016TxHvQLPH6fQtOUN6kHSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 1 Mar 2024 at 05:12, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Shouldn't PG_MULE_INTERNAL point to NULL in pg_enc2gettext_tbl[]?
> That just seems safer to me, and more consistent because its values
> satisfies PG_VALID_ENCODING().
Safety wise it doesn't matter, because gaps in a designated
initializer array will be initialized with 0/NULL. But I agree it's
more consistent, so see attached.
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0003-Simplify-pg_enc2gettext_tbl.patch | text/x-patch | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2024-03-01 04:43:25 | Re: ALTER TABLE SET ACCESS METHOD on partitioned tables |
| Previous Message | Amit Kapila | 2024-03-01 04:31:41 | Re: Synchronizing slots from primary to standby |