| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Spurious pgstat_drop_replslot() call |
| Date: | 2024-03-12 06:17:11 |
| Message-ID: | Ze/zZ4sjydJm9yiA@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Mar 12, 2024 at 02:36:58PM +0900, Michael Paquier wrote:
> On Mon, Mar 11, 2024 at 04:15:40PM +0900, Michael Paquier wrote:
> > That's a slight change in behavior, unfortunately, and it cannot be
> > called a bug as this improves the visibility of the stats after an
> > invalidation, so this is not something that can be backpatched.
>
> I've looked again at that and that was OK on a second look.
Thanks!
> May I
> suggest the attached additions with LWLockHeldByMeInMode to make sure
> that the stats are dropped and created while we hold
> ReplicationSlotAllocationLock?
Yeah, makes fully sense and looks good to me.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-03-12 06:31:48 | Re: UUID v7 |
| Previous Message | Dilip Kumar | 2024-03-12 06:15:33 | Re: Streaming I/O, vectored I/O (WIP) |