| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Assorted typo fixes |
| Date: | 2024-01-03 05:34:39 |
| Message-ID: | ZZTx7y0gPI9SfCIa@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 02, 2024 at 12:34:20PM -0500, Robert Haas wrote:
> 0002-0005 look OK to me, so I committed those as well.
Cool, thanks.
> With regard to 0006, we typically use indexes rather than indices as
> the plural of "index", although exceptions exist.
>
> I haven't looked at the rest.
I got that on a local branch, then got drifted away. I have grouped
0007~0009 together (0007 was on me), and applied them on HEAD.
0010 is indeed the "correct" plural form for vertex I've known but
"vertexes" is not wrong either. Perhaps that's worth changing on
consistency grounds?
8)</literal>, must be identical. It doesn't matter which representation
you choose to be the canonical one, so long as two equivalent values with
- different formattings are always mapped to the same value with the same
+ different formatting are always mapped to the same value with the same
formatting.
I am not sure about this one in 0011 though.. It also feels like this
could be reworded completely.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-01-03 05:54:50 | Re: pg_upgrade and logical replication |
| Previous Message | Nathan Bossart | 2024-01-03 05:14:56 | Re: Adding facility for injection points (or probe points?) for more advanced tests |