| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: reindexing an invalid index should not use ERRCODE_INDEX_CORRUPTED |
| Date: | 2023-12-07 01:32:33 |
| Message-ID: | ZXEgsbDQoPgNN6Rx@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 06, 2023 at 04:33:33PM -0800, Noah Misch wrote:
> On Wed, Dec 06, 2023 at 03:17:12PM +0900, Michael Paquier wrote:
>>> The "cannot" part of the message is also inaccurate, and it's not clear to me
>>> why we have this specific restriction at all. REINDEX INDEX CONCURRENTLY
>>> accepts such indexes, so I doubt it's an implementation gap.
>>
>> If you would reword that, what would you change?
>
> I'd do "skipping reindex of invalid index \"%s.%s\"". If one wanted more,
In line with vacuum.c, that sounds like a good idea at the end.
> errhint("Use DROP INDEX or REINDEX INDEX.") would fit.
I'm OK with this suggestion as well.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| reindex-invalid-errcode-v2.patch | text/x-diff | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2023-12-07 01:38:03 | Re: Change GUC hashtable to use simplehash? |
| Previous Message | David G. Johnston | 2023-12-07 01:21:28 | Re: Emitting JSON to file using COPY TO |