| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gurjeet Singh <gurjeet(at)singh(dot)im>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Change GUC hashtable to use simplehash? |
| Date: | 2023-12-07 01:38:03 |
| Message-ID: | CANWCAZaVRnRHvoArpMAkTFh7FakjyUtOSdeh4vsB93DAi8wVXw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 6, 2023 at 11:48 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Wed, 2023-12-06 at 07:39 +0700, John Naylor wrote:
> > "git grep cstring_hash" found nothing, so not sure what you're
> > asking.
>
> Sorry, I meant string_hash(). Your v5-0002 changes the way hashing
> works for cstrings, and that means it's no longer equivalent to
> hash_bytes with strlen. That's probably fine, but someone might assume
> that they are equivalent.
That's a good point. It might be best to leave string_hash where it is
and remove the comment that it's the default. Then the new function (I
like the name cstring_hash) can live in dynahash.c where it's obvious
what "default" means.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-12-07 01:40:44 | Re: reindexing an invalid index should not use ERRCODE_INDEX_CORRUPTED |
| Previous Message | Michael Paquier | 2023-12-07 01:32:33 | Re: reindexing an invalid index should not use ERRCODE_INDEX_CORRUPTED |