Re: Add new option 'all' to pg_stat_reset_shared()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, boekewurm+postgres(at)gmail(dot)com, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add new option 'all' to pg_stat_reset_shared()
Date: 2023-11-09 01:25:18
Message-ID: ZUw0_tA7g0dkTow8@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 09, 2023 at 10:10:39AM +0900, torikoshia wrote:
> I am a little concerned about that the reset time is not the same and that
> GetCurrentTimestamp() is called multiple times, but I think it would be
> acceptable because the function is probably not used that often and the
> reset time is not atomic in practice.

Arf, right. I misremembered that this is just a clock_timestamp() so
that's not transaction-resilient. Anyway, my take is that this is not
a big deal in practice compared to the usability of the wrapper.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Crisp Lee 2023-11-09 01:29:32 Re: make pg_ctl more friendly
Previous Message Michael Paquier 2023-11-09 01:22:09 Re: ensure, not insure