| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Vik Fearing <vik(at)postgresfriends(dot)org> |
| Cc: | cary huang <hcary328(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add support for AT LOCAL |
| Date: | 2023-10-13 04:07:00 |
| Message-ID: | ZSjCZJrxGL0-wv-G@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 13, 2023 at 02:20:59AM +0200, Vik Fearing wrote:
> On 10/10/23 05:34, Michael Paquier wrote:
> > I am attaching a v5 that addresses the documentation bits, could you
> > look at the business with date.c?
>
> Here is a v6
Thanks for the new version.
> which hopefully addresses all of your concerns.
Mostly ;)
The first thing I did was to extract the doc bits about timezone(zone,
time) for AT TIME ZONE from v6 and applied it independently.
I have then looked at the rest and it looked mostly OK to me,
including the extra description you have added for the fifth example
in the docs. I have tweaked a few things: the regression tests to
make the views a bit more appealing to the eye, an indentation to not
have koel complain and did a catalog bump. Then applied it.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2023-10-13 04:34:19 | Re: Invalidate the subscription worker in cases where a user loses their superuser status |
| Previous Message | Amit Kapila | 2023-10-13 03:59:25 | Re: pg_upgrade's interaction with pg_resetwal seems confusing |