| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag |
| Date: | 2023-10-10 05:58:03 |
| Message-ID: | ZSTn66_BXRZCeaqS@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 10, 2023 at 06:57:05AM +0200, Drouvot, Bertrand wrote:
> Please find attached v9 (v8 rebase due to f483b2090).
I was looking at v8 just before you sent this v9, and still got
annoyed by the extra boolean argument added to InitPostgres(). So
please let me propose to bite the bullet and refactor that, as of the
0001 attached that means less diff footprints in all the callers of
InitPostgres() (I am not wedded to the flag names).
It looks like 0002 had the same issues as f483b209: the worker that
could not be started because of the login restriction could be
detected as stopped by worker_spi_launch(), causing the script to fail
hard.
0002 is basically your v9, able to work with the refactoring from
0001.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-Refactor-InitPostgres-with-flags.patch | text/x-diff | 8.2 KB |
| v10-0002-Allow-background-workers-to-bypass-login-check.patch | text/x-diff | 9.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-10-10 05:59:32 | Re: Minor edit to src/bin/pg_upgrade/IMPLEMENTAION |
| Previous Message | Nishant Sharma | 2023-10-10 05:57:14 | Re: [Code Cleanup] : Small code cleanup in twophase.sql |