From: | Nishant Sharma <nishant(dot)sharma(at)enterprisedb(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [Code Cleanup] : Small code cleanup in twophase.sql |
Date: | 2023-10-10 05:57:14 |
Message-ID: | CADrsxdaZ84tJ9hu9SSgR-PMDk7X+4LpLV0aQfxpZhVaR0V36_w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Any taker or rejector for above? -- It's a very small 'good to have' change
patch for cleanup.
Thanks,
Nishant (EDB).
On Tue, Sep 26, 2023 at 6:31 PM Nishant Sharma <
nishant(dot)sharma(at)enterprisedb(dot)com> wrote:
> Hi,
>
>
> PFA small code cleanup in twophase.sql. Which contains a drop table
> statement for 'test_prepared_savepoint'. Which, to me, appears to be
> missing in the cleanup section of that file.
>
> To support it I have below points:-
>
> 1) Grepping this table 'test_prepared_savepoint' shows occurrences
> only in twophase.out & twophase.sql files. This means that table is
> local to that sql test file and not used in any other test file.
>
> 2) I don't see any comment on why this was not added in the cleanup
> section of twophase.sql, but drop for other two test tables are done.
>
> 3) I ran "make check-world" with the patch and I don't see any failures.
>
> Kindly correct, if I missed anything.
>
>
> Regards,
> Nishant (EDB).
>
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-10-10 05:58:03 | Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag |
Previous Message | Peter Eisentraut | 2023-10-10 05:57:00 | Re: Add const to values and nulls arguments |