Re: [PATCH] Add inline comments to the pg_hba_file_rules view

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, David Zhang <david(dot)zhang(at)highgo(dot)ca>
Subject: Re: [PATCH] Add inline comments to the pg_hba_file_rules view
Date: 2023-09-16 04:18:41
Message-ID: ZQUsoaxQhDFcvmkZ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 15, 2023 at 09:37:23AM +0200, Jim Jones wrote:
> SELECT type, database, user_name, address, c.comment
> FROM  pg_hba_file_rules h, pg_read_conf_comments(h.file_name) c
> WHERE user_name[1]='jim' AND h.line_number = c.line_number ;
>
>  type | database | user_name |  address  | comment
> ------+----------+-----------+-----------+---------
>  host | {db}     | {jim}     | 127.0.0.1 | foo
>  host | {db}     | {jim}     | 127.0.0.1 | bar
>  host | {db}     | {jim}     | 127.0.0.1 | #foo#
> (3 rows)
>
>
> Is it more or less what you had in mind?

That was the idea. I forgot about strpos(), but if you do that, do we
actually need a function in core to achieve that? There are a few
fancy cases with the SQL function you have sent, actually.. strpos()
would grep the first '#' character, ignoring quoted areas.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-09-16 12:39:48 Re: Add 'worker_type' to pg_stat_subscription
Previous Message Erik Rijkers 2023-09-16 03:59:26 Re: JSON Path and GIN Questions