Re: Add 'worker_type' to pg_stat_subscription

On Sat, Sep 16, 2023 at 1:06 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Thu, Sep 14, 2023 at 03:04:19PM -0700, Nathan Bossart wrote:
> > The only reason I didn't apply this already is because IMHO we should
> > adjust the worker types and the documentation for the view to be
> > consistent. For example, the docs say "leader apply worker" but the view
> > just calls them "apply" workers. The docs say "synchronization worker" but
> > the view calls them "table synchronization" workers. My first instinct is
> > to call apply workers "leader apply" workers in the view, and to call table
> > synchronization workers "table synchronization workers" in the docs.
>
> Concretely, like this.
>

I think there is a merit in keeping the worker type as 'sync' or
'synchronization' because these would be used in future for syncing
other objects like sequences. One more thing that slightly looks odd
is the 'leader apply' type of worker, won't this be confusing when
there is no parallel apply worker in the system? In this regard,
probably existing documentation could also be improved.

--
With Regards,
Amit Kapila.