Re: Wrong usage of pqMsg_Close message code?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: pavel(dot)stehule(at)gmail(dot)com, aleksander(at)timescale(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Wrong usage of pqMsg_Close message code?
Date: 2023-08-28 22:53:37
Message-ID: ZO0lcXlwln/Ir09S@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 29, 2023 at 06:12:00AM +0900, Tatsuo Ishii wrote:
> I think EndReplicationCommand needs to be fixed as well.

Yeah, both of you are right here. Anyway, it seems to me that there
is a bit more going on in protocol.h. I have noticed two more things
that are incorrect:
- HandleParallelMessage is missing a message for 'P', but I think that
we should have a code for it as well as part of the parallel query
protocol.
- PqMsg_Terminate can be sent by the frontend *and* the backend, see
fe-connect.c and parallel.c. However, protocol.h documents it as a
frontend-only code.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2023-08-28 23:10:38 Re: Debian 12 gcc warning
Previous Message Michael Paquier 2023-08-28 22:40:11 Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment