Re: Wrong usage of pqMsg_Close message code?

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: michael(at)paquier(dot)xyz
Cc: pavel(dot)stehule(at)gmail(dot)com, aleksander(at)timescale(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Wrong usage of pqMsg_Close message code?
Date: 2023-08-29 01:04:24
Message-ID: 20230829.100424.623781851282219189.t-ishii@sranhm.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Yeah, both of you are right here. Anyway, it seems to me that there
> is a bit more going on in protocol.h. I have noticed two more things
> that are incorrect:
> - HandleParallelMessage is missing a message for 'P', but I think that
> we should have a code for it as well as part of the parallel query
> protocol.

I did not know this. Why is this not explained in the frontend/backend
protocol document?

> - PqMsg_Terminate can be sent by the frontend *and* the backend, see
> fe-connect.c and parallel.c. However, protocol.h documents it as a
> frontend-only code.

I do not blame protocol.h because our frontend/backend protocol
document also stats that it's a frontend only message. Someone who
started to use 'X' in backend should have added that in the
documentation.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stuart McGraw 2023-08-29 01:23:48 Restoring default privileges on objects
Previous Message Bruce Momjian 2023-08-29 01:00:37 Re: Debian 12 gcc warning