Re: [PATCH] Check more invariants during syscache initialization

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zhang Mingli <zmlpostgres(at)gmail(dot)com>
Subject: Re: [PATCH] Check more invariants during syscache initialization
Date: 2023-07-27 01:05:46
Message-ID: ZMHC6sq7qQSB7Zoz@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 26, 2023 at 03:28:55PM +0100, Dagfinn Ilmari Mannsåker wrote:
> Shouldn't these be calling `OidIsValid(…)`, not comparing directly to
> `InvalidOid`?

I think that they should use OidIsValid() on correctness ground, and
that's the style I prefer. Now, I don't think that these are worth
changing now except if some of the surrounding code is changed for a
different reason. One reason is that this increases the odds of
conflicts when backpatching on a stable branch.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2023-07-27 01:13:39 Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication
Previous Message Michael Paquier 2023-07-27 00:57:09 Re: Improve pg_stat_statements by making jumble handle savepoint names better