Re: Improve pg_stat_statements by making jumble handle savepoint names better

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve pg_stat_statements by making jumble handle savepoint names better
Date: 2023-07-27 00:57:09
Message-ID: ZMHA5fgtzQERWn8C@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 26, 2023 at 07:53:02AM +0900, Michael Paquier wrote:
> I think that I'm OK with your proposal as savepoint names are in
> defined places in these queries (contrary to some of the craziness
> with BEGIN and the node structure of TransactionStmt, for example).
>
> Has somebody an opinion or a comment to share?

Well, on second look this is really simple, so I've applied that after
adding back some comments that ought to be and simplifying a bit the
tests (less queries, same coverage).
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-07-27 01:05:46 Re: [PATCH] Check more invariants during syscache initialization
Previous Message David Rowley 2023-07-27 00:17:20 Re: Performance degradation on concurrent COPY into a single relation in PG16.