Re: pgsql: Fix the display of UNKNOWN message type in apply worker.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Kapila <akapila(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix the display of UNKNOWN message type in apply worker.
Date: 2023-07-25 05:20:48
Message-ID: ZL9bsGhthne6FaVV@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Jul 25, 2023 at 03:52:32AM +0000, Amit Kapila wrote:
> Fix the display of UNKNOWN message type in apply worker.
>
> We include the message type while displaying an error context in the
> apply worker. Now, while retrieving the message type string if the
> message type is unknown we throw an error that will hide the original
> error. So, instead, we need to simply return the string indicating an
> unknown message type.

koel is complaining after this commit:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-07-25%2004%3A49%3A03
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Masahiko Sawada 2023-07-25 06:13:07 pgsql: Remove unnecessary checks for indexes for REPLICA IDENTITY FULL
Previous Message Michael Paquier 2023-07-25 04:41:13 pgsql: Optimize WAL insertion lock acquisition and release with some at