| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix the display of UNKNOWN message type in apply worker. |
| Date: | 2023-07-25 10:47:02 |
| Message-ID: | CAA4eK1K4Ttte5scwj0uu5boJyU3dfNeBQc1okMtGE0_zwQp-Yw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, Jul 25, 2023 at 10:51 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Jul 25, 2023 at 03:52:32AM +0000, Amit Kapila wrote:
> > Fix the display of UNKNOWN message type in apply worker.
> >
> > We include the message type while displaying an error context in the
> > apply worker. Now, while retrieving the message type string if the
> > message type is unknown we throw an error that will hide the original
> > error. So, instead, we need to simply return the string indicating an
> > unknown message type.
>
> koel is complaining after this commit:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-07-25%2004%3A49%3A03
>
Pushed a fix.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-07-26 03:07:43 | pgsql: Document more assumptions of LWLock variable changes with WAL in |
| Previous Message | Amit Kapila | 2023-07-25 07:13:29 | pgsql: Fix code indentation vioaltion introduced in commit d38ad8e31d. |