Add TLI number to name of files generated by pg_waldump --save-fullpage

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, David Christensen <david(dot)christensen(at)crunchydata(dot)com>
Subject: Add TLI number to name of files generated by pg_waldump --save-fullpage
Date: 2023-06-27 06:12:43
Message-ID: ZJp921+nITFnvBVS@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,
(Fujii-san and David in CC.)

Fujii-san has reported on Twitter that we had better add the TLI
number to what pg_waldump --save-fullpage generates for the file names
of the blocks, as it could be possible that we overwrite some blocks.
This information can be added thanks to ws_tli, that tracks the TLI of
the opened segment.

Attached is a patch to fix this issue, adding an open item assigned to
me. The file format is documented in the TAP test and the docs, the
two only places that would need a refresh.

Thoughts or comments?
--
Michael

Attachment Content-Type Size
v1-0001-Add-timeline-to-file-names-generated-with-pg_wald.patch text/x-diff 3.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-06-27 06:26:43 Re: Clean up JumbleQuery() from query text
Previous Message Daniel Gustafsson 2023-06-27 06:10:42 Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs