| From: | David Christensen <david(dot)christensen(at)crunchydata(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Add TLI number to name of files generated by pg_waldump --save-fullpage |
| Date: | 2023-06-27 16:53:10 |
| Message-ID: | CAOxo6XKCL3q-Nv8aTzaHFLdjfSSg7=3vv5aWoJmJELfgVJsFiA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 27, 2023 at 1:12 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Hi all,
> (Fujii-san and David in CC.)
>
> Fujii-san has reported on Twitter that we had better add the TLI
> number to what pg_waldump --save-fullpage generates for the file names
> of the blocks, as it could be possible that we overwrite some blocks.
> This information can be added thanks to ws_tli, that tracks the TLI of
> the opened segment.
>
> Attached is a patch to fix this issue, adding an open item assigned to
> me. The file format is documented in the TAP test and the docs, the
> two only places that would need a refresh.
>
> Thoughts or comments?
Patch looks good, but agreed that that comment should also be fixed.
Thanks!
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Roberto Mello | 2023-06-27 16:54:28 | Re: PostgreSQL 16 Beta 2 release announcement draft |
| Previous Message | Jacob Champion | 2023-06-27 16:47:09 | Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs |