| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: [PATCH] Using named captures in Catalog::ParseHeader() |
| Date: | 2023-06-14 01:03:24 |
| Message-ID: | ZIkR3LzEUjCcK2CH@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 01, 2023 at 01:12:22PM +0100, Dagfinn Ilmari Mannsåker wrote:
> While I was rewriting the regexes I noticed that they were inconsistent
> about whether they accepted whitespace in the parameter lists, so I took
> the liberty to make them consistently allow whitespace after the opening
> paren and the commas, which is what most of them already did.
That's the business with \s* in CATALOG. Is that right? Indeed,
that's more consistent.
> I've verified that the generated postgres.bki is identical to before,
> and all tests pass.
I find that pretty cool. Nice. Patch looks OK from here.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-06-14 01:05:51 | Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c) |
| Previous Message | Kyotaro Horiguchi | 2023-06-14 01:01:59 | Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c) |