| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: [PATCH] Using named captures in Catalog::ParseHeader() |
| Date: | 2023-06-14 09:30:23 |
| Message-ID: | 875y7qs85s.fsf@wibble.ilmari.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Thu, Jun 01, 2023 at 01:12:22PM +0100, Dagfinn Ilmari Mannsåker wrote:
>> While I was rewriting the regexes I noticed that they were inconsistent
>> about whether they accepted whitespace in the parameter lists, so I took
>> the liberty to make them consistently allow whitespace after the opening
>> paren and the commas, which is what most of them already did.
>
> That's the business with \s* in CATALOG. Is that right? Indeed,
> that's more consistent.
Yes, \s* means "zero or more whitespace characters".
>> I've verified that the generated postgres.bki is identical to before,
>> and all tests pass.
>
> I find that pretty cool. Nice. Patch looks OK from here.
Thanks for the review!
- ilmari
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-06-14 09:44:23 | Re: Do we want a hashset type? |
| Previous Message | Tomas Vondra | 2023-06-14 09:05:11 | Re: TRAP: FailedAssertion("prev_first_lsn < cur_txn->first_lsn", File: "reorderbuffer.c", Line: 927, PID: 568639) |