Re: Support logical replication of DDLs

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Wei Wang (Fujitsu)" <wangw(dot)fnst(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, "Yu Shi (Fujitsu)" <shiy(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Runqi Tian <runqidev(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, li jie <ggysxcq(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zheng Li <zhengli10(at)gmail(dot)com>
Subject: Re: Support logical replication of DDLs
Date: 2023-06-13 21:56:42
Message-ID: ZIjmGhPWdoJUfjjE@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Tue, Jun 13, 2023 at 06:49:42PM +0530, Amit Kapila wrote:
> We have to choose one of the approaches between 0001 and 0008. I feel
> we don't need an intermediate ObjTree representation as that adds
> overhead and an additional layer which is not required. As mentioned
> in my previous email I think as a first step we should merge 0001 and
> 0008 and avoid having an additional ObjTree layer unless you or others
> feel we need it. I think that will reduce the overall patch size and
> help us to focus on one of the approaches.

Similar impression here. I found ObjTree actually confusing compared
to the JSON blobs generated.

> Surely, as suggested by
> you, we should also evaluate if we can generate this code for the
> various command types.

Thanks.
--
Michael

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message raf 2023-06-14 07:48:27 Re: SOC II Type 2 report.
Previous Message Tom Lane 2023-06-13 20:15:41 Re: Exclusion constraint with negated operator?

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-06-13 22:02:58 Re: ERROR: wrong varnullingrels (b 3) (expected (b)) for Var 2/1
Previous Message Nathan Bossart 2023-06-13 21:38:14 Re: Document that server will start even if it's unable to open some TCP/IP ports