| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: v16 fails to build w/ Visual Studio 2015 |
| Date: | 2023-06-12 00:40:52 |
| Message-ID: | ZIZplH/o7DIWQ8GY@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 07, 2023 at 11:35:34PM +0200, Peter Eisentraut wrote:
> I kind of like the style where there is only one return at the end, because
> it makes it easier to inject debugging code that inspects the return value.
I kind of disagree here, the previous style is a bit ugly-ish, with
the code generated by gen_node_support.pl being dependent on this
local call because it is necessary to know about return_value:
- if (false)
- ;
#include "readfuncs.switch.c"
So +1 for what's proposed.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-06-12 00:50:58 | Re: v16 fails to build w/ Visual Studio 2015 |
| Previous Message | Michael Paquier | 2023-06-12 00:17:53 | Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific |