| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: v16 fails to build w/ Visual Studio 2015 |
| Date: | 2023-06-07 21:35:34 |
| Message-ID: | 99515c92-dd99-b728-0195-c38b8fd95d2f@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07.06.23 23:16, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
>> Visual Studio 2015 version "14.0.25431.01 Update 3" has an apparent compiler
>> bug that causes the build to fail with "readfuncs.switch.c(522): fatal error
>> C1026: parser stack overflow, program too complex (compiling source file
>> src/backend/nodes/readfuncs.c)". While I wouldn't mind revoking support for
>> Visual Studio 2015, changing the code to cope is easy. See attached.
>
> +1, I think this reads better anyway.
I kind of like the style where there is only one return at the end,
because it makes it easier to inject debugging code that inspects the
return value.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-06-07 21:37:21 | Re: Let's make PostgreSQL multi-threaded |
| Previous Message | Peter Eisentraut | 2023-06-07 21:34:09 | Re: v16 fails to build w/ Visual Studio 2015 |