Re: MERGE lacks ruleutils.c decompiling support!?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: MERGE lacks ruleutils.c decompiling support!?
Date: 2023-05-06 02:46:06
Message-ID: ZFW/bs6KWmJvgp+d@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 05, 2023 at 05:06:34PM -0400, Tom Lane wrote:
> I did a bit of review and more work on this:
>
> * Added the missing OVERRIDING support
>
> * Played around with the pretty-printing indentation
>
> * Improved test coverage, and moved the test to rules.sql where
> I thought it fit more naturally.
>
> I think we could probably commit this, though I've not tried it
> in v15 yet.

Seems rather OK..

+WHEN NOT MATCHED
+ AND s.a > 100
+ THEN INSERT (id, data) OVERRIDING SYSTEM VALUE
+ VALUES (s.a, DEFAULT)

About OVERRIDING, I can see that this is still missing coverage for
OVERRIDING USER VALUE.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-05-06 02:49:15 Re: MERGE lacks ruleutils.c decompiling support!?
Previous Message Michael Paquier 2023-05-06 02:37:05 Re: Autogenerate some wait events code and documentation