| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2023-04-12 14:57:51 |
| Message-ID: | ZDbG77gXJLTHfo3V@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 24, 2023 at 10:46:37AM -0400, Robert Haas wrote:
> On Thu, Mar 23, 2023 at 4:11 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > On Wed, Mar 22, 2023 at 10:09 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > > > BaseBackupSync is not documented
> > > > BaseBackupWrite is not documented
> > >
> > > [Resending with trimmed CC: list, because the mailing list told me to
> > > due to a blocked account, sorry if you already got the above.]
> >
> > Bummer. I'll write a patch to fix that tomorrow, unless somebody beats me to it.
>
> Here's a patch for that, and a patch to add the missing error check
> Peter noticed.
I think these maybe got forgotten ?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexandr Nikulin | 2023-04-12 15:00:07 | Re: Improve the performance of nested loop join in the case of partitioned inner table |
| Previous Message | Melanie Plageman | 2023-04-12 14:57:17 | Re: Wrong results from Parallel Hash Full Join |