| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2023-03-24 14:46:37 |
| Message-ID: | CA+TgmoaDMmt=dvOMZE_D9EtViih7O7FYGm9NVjH=HCrNU7KYOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 23, 2023 at 4:11 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Mar 22, 2023 at 10:09 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > > BaseBackupSync is not documented
> > > BaseBackupWrite is not documented
> >
> > [Resending with trimmed CC: list, because the mailing list told me to
> > due to a blocked account, sorry if you already got the above.]
>
> Bummer. I'll write a patch to fix that tomorrow, unless somebody beats me to it.
Here's a patch for that, and a patch to add the missing error check
Peter noticed.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-missing-documentation-entries-for-new-base-backu.patch | application/octet-stream | 1.2 KB |
| 0002-basebackup_to_shell-Add-missing-error-check.patch | application/octet-stream | 985 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-03-24 14:47:08 | Re: Non-superuser subscription owners |
| Previous Message | Robert Haas | 2023-03-24 14:00:36 | Re: running logical replication as the subscription owner |