Re: pgindent vs. git whitespace check

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent vs. git whitespace check
Date: 2023-03-30 14:48:25
Message-ID: ZCWhOdUUqKBWIabu@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 29, 2023 at 08:26:23PM +0200, Daniel Gustafsson wrote:
> > On 29 Mar 2023, at 19:18, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > We would have to convert all supported branches, and tell all forks to
> > do the same (hopefully at the same time). The new standard would then
> > be for all single-line comments to use // instead of /* ... */.
>
> That still leaves every patch which is in flight on -hackers, and conflicts in
> local development trees etc. It's doable (apart from forks, but that cannot be
> our core concern), but I personally can't see the price paid justify the result.

Yes, this would have to be done at the start of a new release cycle.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Embrace your flaws. They make you human, rather than perfect,
which you will never be.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-03-30 15:00:01 Re: meson/msys2 fails with plperl/Strawberry
Previous Message Peter Eisentraut 2023-03-30 14:01:46 Re: Transparent column encryption