| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgindent vs. git whitespace check |
| Date: | 2023-03-29 18:26:23 |
| Message-ID: | 1F36DFB5-0B3C-413F-B125-35B6E1BC3F20@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 29 Mar 2023, at 19:18, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Thu, Feb 23, 2023 at 09:36:00AM +0100, Daniel Gustafsson wrote:
>>> On 23 Feb 2023, at 05:48, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Mass conversion of /* to // style would answer that,
>>> but would also create an impossible back-patching problem.
>>
>> Yeah, that sounds incredibly invasive.
>
> I am replying late here but ...
>
> We would have to convert all supported branches, and tell all forks to
> do the same (hopefully at the same time). The new standard would then
> be for all single-line comments to use // instead of /* ... */.
That still leaves every patch which is in flight on -hackers, and conflicts in
local development trees etc. It's doable (apart from forks, but that cannot be
our core concern), but I personally can't see the price paid justify the result.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2023-03-29 18:29:25 | Re: Add pg_walinspect function with block info columns |
| Previous Message | Karl O. Pinc | 2023-03-29 18:23:33 | Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences |