| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUG] pg_stat_statements and extended query protocol |
| Date: | 2023-04-05 22:09:37 |
| Message-ID: | ZC3xocv5AKZMxKs9@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 05, 2023 at 05:39:13PM -0400, Tom Lane wrote:
> v5 seems OK to me except I think CreateExecutorState() should explicitly
> zero the new es_total_processed field, alongside zeroing es_processed.
> (I realize that the makeNode would have done it already, but our
> coding conventions generally run towards not relying on that. This is
> mainly for greppability, so you can find where a field is initialized.)
Makes sense to me. I'll look at that again today, potentially apply
the fix on HEAD.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Imseih (AWS), Sami | 2023-04-05 22:16:19 | Re: [BUG] pg_stat_statements and extended query protocol |
| Previous Message | Michael Paquier | 2023-04-05 22:06:47 | Re: GUC for temporarily disabling event triggers |