| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, melanieplageman(at)gmail(dot)com, boekewurm+postgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add pg_walinspect function with block info columns |
| Date: | 2023-03-22 06:22:14 |
| Message-ID: | ZBqelplA7Nn7kOfZ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 20, 2023 at 05:00:25PM -0700, Peter Geoghegan wrote:
> I think that we should also make the description output column display
> NULLs for those records that don't output any description string. This
> at least includes the "FPI" record type from the "XLOG" rmgr.
> Alternatively, we could find a way of making it show a description.
An empty StringInfo is sent to rm_desc, so hardcoding something in
pg_walinspect to show some data does not look right to me. Saying
that, using NULL when there is no description is OK by me, as much as
is using an empty string because it maps with the reality of the empty
StringInfo sent to the rm_desc callback.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-03-22 06:30:11 | Re: Commitfest 2023-03 starting tomorrow! |
| Previous Message | Amit Kapila | 2023-03-22 06:03:33 | Re: add log messages when replication slots become active and inactive (was Re: Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData?) |