| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | bharath(dot)rupireddyforpostgres(at)gmail(dot)com, michael(at)paquier(dot)xyz, melanieplageman(at)gmail(dot)com, boekewurm+postgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add pg_walinspect function with block info columns |
| Date: | 2023-03-21 00:00:25 |
| Message-ID: | CAH2-WzmA=gcryuRSh_EvUNrj=h6-_-TGsgwD=JeF_LHP1Miqjg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 20, 2023 at 4:51 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> The new pg_get_wal_block_info outputs columns in an order that doesn't
> seem like the most useful possible order to me. This gives us another
> reason to have separate GetWALRecordInfo and GetWALBlockInfo utility
> functions rather than sharing logic for building output tuples.
One more piece of feedback for Bharath:
I think that we should also make the description output column display
NULLs for those records that don't output any description string. This
at least includes the "FPI" record type from the "XLOG" rmgr.
Alternatively, we could find a way of making it show a description.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2023-03-21 00:11:37 | Re: Request for comment on setting binary format output per session |
| Previous Message | Peter Geoghegan | 2023-03-20 23:51:19 | Re: Add pg_walinspect function with block info columns |