| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, bruce(at)momjian(dot)us |
| Subject: | Re: optimize file transfer in pg_upgrade |
| Date: | 2025-03-18 17:47:01 |
| Message-ID: | Z9mxlf5uVuk2DziP@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 18, 2025 at 01:37:02PM -0400, Andres Freund wrote:
> I'd add a few more complications:
>
> - Create and test a relation that was rewritten, to ensure we test the
> relfilenode != oid case and one that isn't rewritten.
+1
> - Perhaps create a tablespace?
+1, I don't think we have much, if any, coverage of pg_upgrade with
non-default tablespaces.
> - Do we need a new old cluster for each of the modes? That seems like wasted
> time? I guess it's required for --link...
It'll also be needed for --swap. We could optionally save the old cluster
for a couple of modes if we really wanted to. *shrug*
I'll work on the first two...
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-03-18 17:49:00 | Re: Optimization for lower(), upper(), casefold() functions. |
| Previous Message | Andres Freund | 2025-03-18 17:39:12 | Re: md.c vs elog.c vs smgrreleaseall() in barrier |