| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Alexander Borisov <lex(dot)borisov(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Optimization for lower(), upper(), casefold() functions. |
| Date: | 2025-03-18 17:49:00 |
| Message-ID: | 109244.1742320140@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> On Tue, 2025-03-18 at 11:11 -0400, Tom Lane wrote:
>> Also, probably better to make it const:
>>
>> -static const pg_wchar *casekind_map[NCaseKind] =
>> +static const pg_wchar * const casekind_map[NCaseKind] =
> Was this a general suggestion, or did you see something in particular
> that would make it more optimizable this way?
No, just a general style position that tables that aren't supposed
to change should be const. Cases like this are a tad insidious
because it looks like you did make the table const, only you didn't.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-03-18 17:50:10 | Re: optimize file transfer in pg_upgrade |
| Previous Message | Nathan Bossart | 2025-03-18 17:47:01 | Re: optimize file transfer in pg_upgrade |