Re: Tidy recent code bloat in pg_creatersubscriber::cleanup_objects_atexit

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Tidy recent code bloat in pg_creatersubscriber::cleanup_objects_atexit
Date: 2025-03-16 11:09:36
Message-ID: Z9axcAh153fFHWGW@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 11, 2025 at 04:06:14PM +0900, Michael Paquier wrote:
> Right. This improves the clarity of the code, so agreed about the use
> of a local variable here.

More code paths of pg_createsubscriber.c have similar loops, but this
is the only one where LogicalRepInfo can be used. So, applied as you
have suggested, without touching the other loops.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2025-03-16 12:44:10 Re: Large expressions in indexes can't be stored (non-TOASTable)
Previous Message Masahiko Sawada 2025-03-16 05:39:48 Re: Add contrib/pg_logicalsnapinspect