| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, "shveta(dot)malik(at)gmail(dot)com" <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add contrib/pg_logicalsnapinspect |
| Date: | 2025-03-16 05:39:48 |
| Message-ID: | CAD21AoBQ-qed3-4jj701BmpKxE_zDBc=1mERGNWhCW-mzMpr_w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 13, 2025 at 6:20 PM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> On Tue, Mar 11, 2025, at 7:34 PM, Masahiko Sawada wrote:
>
> Pushed.
>
>
> pgindent is saying this commit included some extra tabs.
>
> git diff
> diff --git a/contrib/pg_logicalinspect/pg_logicalinspect.c b/contrib/pg_logicalinspect/pg_logicalinspect.c
> index ff6c682679f..5a44718bea8 100644
> --- a/contrib/pg_logicalinspect/pg_logicalinspect.c
> +++ b/contrib/pg_logicalinspect/pg_logicalinspect.c
> @@ -86,7 +86,7 @@ parse_error:
> ereport(ERROR,
> errmsg("invalid snapshot file name \"%s\"", filename));
>
> - return InvalidXLogRecPtr; /* keep compiler quiet */
> + return InvalidXLogRecPtr; /* keep compiler quiet */
> }
Yes, David fixed it in commit b955df44340.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-03-16 11:09:36 | Re: Tidy recent code bloat in pg_creatersubscriber::cleanup_objects_atexit |
| Previous Message | Laurenz Albe | 2025-03-16 05:29:17 | Re: Disabling vacuum truncate for autovacuum |