Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, tharakan(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string
Date: 2025-03-12 19:03:04
Message-ID: Z9HaaODoGk1-4_SL@nathan
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Tue, Mar 11, 2025 at 03:34:18PM -0700, Masahiko Sawada wrote:
> Pushed.

I'm seeing warnings for the CI build on Windows [0] that appear to be
related to this commit:

c:\cirrus\contrib\pg_logicalinspect\pg_logicalinspect.c(88) : warning C4715: 'parse_snapshot_filename': not all control paths return a value

I suspect we just need to do something like commit fe4ecd0 and return
InvalidXLogRecPtr after the ERROR.

[0] https://api.cirrus-ci.com/v1/task/4876492255002624/logs/build.log

--
nathan

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Dean Rasheed 2025-03-12 19:23:39 Re: BUG #18830: ExecInitMerge Segfault on MERGE
Previous Message Tender Wang 2025-03-12 16:11:24 Re: BUG #18830: ExecInitMerge Segfault on MERGE