| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, tharakan(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string |
| Date: | 2025-03-12 21:33:36 |
| Message-ID: | CAD21AoC8s0e0umq6dbbQwYMVoUs2xd8L8LUY5Vjj5c7a_-9usQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Mar 12, 2025 at 12:03 PM Nathan Bossart
<nathandbossart(at)gmail(dot)com> wrote:
>
> On Tue, Mar 11, 2025 at 03:34:18PM -0700, Masahiko Sawada wrote:
> > Pushed.
>
> I'm seeing warnings for the CI build on Windows [0] that appear to be
> related to this commit:
>
> c:\cirrus\contrib\pg_logicalinspect\pg_logicalinspect.c(88) : warning C4715: 'parse_snapshot_filename': not all control paths return a value
>
> I suspect we just need to do something like commit fe4ecd0 and return
> InvalidXLogRecPtr after the ERROR.
Thank you for the report! David also reported the same issue[1]. I've
just pushed the fix.
BTW how did you catch the warning? I checked before the push if the
change had passed the CI tests (completed with green status). But when
checking the build log now, I can see the warning in the build logs.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-03-12 22:00:46 | Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string |
| Previous Message | Nathan Bossart | 2025-03-12 21:05:05 | Re: BUG #18839: ARMv7 builds fail due to missing __crc32cw and similar |