Re: Missing [NO] INDENT flag in XMLSerialize backward parsing

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Subject: Re: Missing [NO] INDENT flag in XMLSerialize backward parsing
Date: 2025-02-21 11:46:03
Message-ID: Z7hne2Ba5L5Z0VcG@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 21, 2025 at 12:29:12PM +0100, Jim Jones wrote:
> For future reference, what’s the best way to verify this myself? The
> buildfarm was all green.

Don't worry, we are all trapped by that at some point.

One way would be to generate by yourself dumps from an older version
by yourself, as documented by src/bin/pg_upgrade/TESTING, part DETAILS
(the part about USE_MODULE_DB=1 is very important). Then you can
reuse the SQL files by specifying an old dump files in the TAP tests
of pg_upgrade. The buildfarm does exactly that.

For every commit, doing this much testing is a bit annoying, and I
face this issue less than once a year for anything I apply. So let's
say that I trust the buildfarm to report back at this stage ;)
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2025-02-21 11:48:21 Re: Support POSITION with nondeterministic collations
Previous Message Ranier Vilela 2025-02-21 11:44:15 Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)