Re: Doc fix of aggressive vacuum threshold for multixact members storage

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: Sami Imseih <samimseih(at)gmail(dot)com>, Alex Friedman <alexf01(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Doc fix of aggressive vacuum threshold for multixact members storage
Date: 2025-02-26 09:40:08
Message-ID: Z77heCxm+vxJafQB@ip-10-97-1-34.eu-west-3.compute.internal
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, Feb 26, 2025 at 02:04:38PM +0700, John Naylor wrote:
> On Wed, Feb 5, 2025 at 2:23 AM Sami Imseih <samimseih(at)gmail(dot)com> wrote:
> >
> > I rather we not touch the .c file for this update. It's unlikely the actual
> > computation will change.
>
> I'm on the fence about putting a hint in the C file, but the
> computation has changed in the past, see commit b4d4ce1d50bbdf , so
> it's a reasonable idea.

Thanks for sharing your thoughts!

I think that the more safeguard we put to avoid code and doc discrepancy the
better (though I agree that this "safeguard" is not perfect but probably better
than none).

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2025-02-26 09:46:24 Re: Anti join confusion
Previous Message Maxim Orlov 2025-02-26 09:33:16 Re: Spinlock can be released twice in procsignal.c