Re: Make pg_stat_io view count IOs as bytes instead of blocks

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Make pg_stat_io view count IOs as bytes instead of blocks
Date: 2025-01-09 08:11:02
Message-ID: Z3-ElvWE_KkzqnwZ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 09, 2025 at 10:15:20AM +0300, Nazir Bilal Yavuz wrote:
> I am a bit confused, are you suggesting these two alternatives:
> 1- Making pgstat_count_io_op_n() static and continuing to use
> pgstat_count_io_op() as it is.
> 2- Removing pgstat_count_io_op() and instead using
> pgstat_count_io_op_n() everywhere.

Either of these options is OK by me. The current state of things just
seems a bit strange because we publish a routine that's used nowhere.
If you have plans for it in a different patch, that's also fine.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Давыдов Виталий 2025-01-09 08:21:38 Re: An improvement of ProcessTwoPhaseBuffer logic
Previous Message Bertrand Drouvot 2025-01-09 08:05:26 Re: Reorder shutdown sequence, to flush pgstats later