Re: Statistics Import and Export

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org
Subject: Re: Statistics Import and Export
Date: 2024-12-26 18:54:41
Message-ID: Z22mcdRo_jTcA7nb@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 11, 2024 at 10:49:53PM -0500, Corey Huinker wrote:
> From cf4e731db9ffaa4e89d7c5d14b32668529c8c89a Mon Sep 17 00:00:00 2001
> From: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
> Date: Fri, 8 Nov 2024 12:27:50 -0500
> Subject: [PATCH v34 11/11] Add --force-analyze to vacuumdb.
>
> The vacuumdb options of --analyze-in-stages and --analyze-only are often
> used after a restore from a dump or a pg_upgrade to quickly rebuild
> stats on a databse.
>
> However, now that stats are imported in most (but not all) cases,
> running either of these commands will be at least partially redundant,
> and will overwrite the stats that were just imported, which is a big
> POLA violation.
>
> We could add a new option such as --analyze-missing-in-stages, but that
> wouldn't help the userbase that grown accustomed to running
> --analyze-in-stages after an upgrade.
>
> The least-bad option to handle the situation is to change the behavior
> of --analyze-only and --analyze-in-stages to only analyze tables which
> were missing stats before the vacuumdb started, but offer the
> --force-analyze flag to restore the old behavior for those who truly
> wanted it.

I am _again_ not happy with this part of the patch. Please reply to the
criticism in my November 19th email:

https://www.postgresql.org/message-id/Zz0T1BENIFDnXmwf@momjian.us

rather than ignoring it and posting the same version of the patch.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Do not let urgent matters crowd out time for investment in the future.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2024-12-26 19:26:51 Re: attndims, typndims still not enforced, but make the value within a sane threshold
Previous Message Bruce Momjian 2024-12-26 18:45:51 Re: Statistics Import and Export