Re: pg_createsubscriber TAP test wrapping makes command options hard to read.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date: 2024-12-13 00:40:43
Message-ID: Z1uCi59vIh5YLhvK@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 12, 2024 at 06:03:33PM +0000, Dagfinn Ilmari Mannsåker wrote:
> On Thu, 12 Dec 2024, at 17:52, Andrew Dunstan wrote:
>> I'd rather get rid of those and just use the long options.
>
> Yeah, that is more self-documenting, so I'll do that while I'm at it.

Agreed. I tend to prefer long options too. That's less mapping to
think about the intentions behind some tests when reading their code.

The idea of using fat commas is neat, Ilmari. I didn't suspect that
this one was possible to trick perltidy.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2024-12-13 00:55:52 Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Previous Message Michael Paquier 2024-12-13 00:02:45 Re: Memory leak in WAL sender with pgoutput (v10~)