| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Peter Smith" <smithpb2250(at)gmail(dot)com>, "Michael Paquier" <michael(at)paquier(dot)xyz>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_createsubscriber TAP test wrapping makes command options hard to read. |
| Date: | 2024-12-12 18:03:33 |
| Message-ID: | 105f432a-6b0b-42d4-9061-65d263279be7@app.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 12 Dec 2024, at 17:52, Andrew Dunstan wrote:
> On 2024-12-12 Th 12:08 PM, Dagfinn Ilmari Mannsåker wrote:
>>
>> command_ok(
>> [
>> 'pg_dump',
>> ('--schema', 'pg_catalog'),
>> ('-f', $outputdir . '/catalogs_primary.dump'),
>> '--no-sync',
>> ('-p', $node_primary->port),
>> '--no-unlogged-table-data',
>> 'regression'
>> ],
>> 'dump catalogs of primary server');
>>
>> I think the fat comma is much nicer than this, so I'd like to convert
>> these too (and replace some of the concatenations with interpolation).
>>
>> Technically the quotes aren't necessary around single-dash options
>> before => since unary minus works on strings as well as numbers, but
>> I'll leave them in for consistency.
>
> I'd rather get rid of those and just use the long options.
Yeah, that is more self-documenting, so I'll do that while I'm at it.
--
- ilmari
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2024-12-12 18:08:06 | Re: UUID v7 |
| Previous Message | Andrew Dunstan | 2024-12-12 17:52:09 | Re: pg_createsubscriber TAP test wrapping makes command options hard to read. |