Re: pg_createsubscriber TAP test wrapping makes command options hard to read.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date: 2024-12-12 05:02:13
Message-ID: Z1puVVhI7n8Qia9b@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 12, 2024 at 03:24:42PM +1100, Peter Smith wrote:
> PSA v2-0001. This time it can survive pgperltidy unchanged.

Confirmed. It looks to apply cleanly to v17 as well. Better to
backpatch to avoid conflict frictions, even if it's cosmetic.

> In passing I also removed the duplicated '--verbose' and changed the
> 'Pub2' case mentioned in the original post.

Right. I didn't notice this dup in "run pg_createsubscriber on node
S". All the commands of the test seem to be in order with what you've
attached, so LGTM.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-12-12 05:07:23 Re: Fix comments related to pending statistics
Previous Message Michael Paquier 2024-12-12 04:52:03 Re: per backend I/O statistics